CLIMADA-project / climada_python

Python (3.8+) version of CLIMADA
GNU General Public License v3.0
291 stars 115 forks source link

Add functions to compute, plot, store the local hazard exceedence intensity and RP maps #857

Open simonameiler opened 3 months ago

simonameiler commented 3 months ago

Changes proposed in this PR:

This PR fixes #854

PR Author Checklist

PR Reviewer Checklist

emanuel-schmid commented 2 weeks ago

@simonameiler looks like the branch is not yet up to date with the develop branch and, e.g., changes from have been reversed. I'd suggest to merge from develop the sooner the better. Merging conflicts usually get worse the longer the merging is postponed. 😟

simonameiler commented 2 weeks ago

@simonameiler looks like the branch is not yet up to date with the develop branch and, e.g., changes from have been reversed. I'd suggest to merge from develop the sooner the better. Merging conflicts usually get worse the longer the merging is postponed. 😟

Thank you for the hint. I handed the pull request off to @ValentinGebhart

ValentinGebhart commented 1 week ago

I don't know how to resolve the issue that, even after merging develop back into this branch, many of the changes made to develop are not transferred here. One solution would be to create a new branch from develop (say "feature/write_haz_rp_maps2") and add the new functions again there. Do you think that this is fine or do you see a better solution? @emanuel-schmid @chahank

chahank commented 1 week ago

@ValentinGebhart : keeping it simple is good to me, so just making a new branch is fine for me. Just then delete the old one.