Improve impact calc error messages when there is a mismatch of impf ids between exposures and impfset

luseverin commented 3 months ago

Changes proposed in this PR:

Add a test in ImpactCalc.impact(exposures, impfset, hazard) to handle AttributeError arising when an impact function id contained in the exposures has no matching impact function in the impact function set.
Change previous AttributeError: 'list' has no attribute 'calc_mdr' to a more explanatory error message

This PR fixes #669 (reopened)

PR Author Checklist

[x] Read the Contribution Guide
[x] Correct target branch selected (if unsure, select develop)
[x] Descriptive pull request title added
[x] Source branch up-to-date with target branch
[x] Documentation updated
[x] Tests updated
[x] Tests passing
[x] No new linter issues
[x] Changelog updated

PR Reviewer Checklist

[x] Read the Contribution Guide
[x] CLIMADA Reviewer Checklist passed
[x] Tests passing
[x] No new linter issues

luseverin commented 3 months ago

Thanks for the review! I think I have adressed all your comments. I also modified the author's list and changelog. Let me know if there's anything else.

emanuel-schmid commented 3 months ago

Good catch!

chahank commented 2 months ago

The compatibility test with petals is failing, but I think it is unrelated to this PR. @emanuel-schmid @luseverin are we ready to merge?

luseverin commented 2 months ago

It also does not seem to me that the tests failing are related to the PR. So ready to merge from my side.

emanuel-schmid commented 2 months ago

Thanks a lot!

CLIMADA-project / climada_python

Improve impact calc error messages when there is a mismatch of impf ids between exposures and impfset #863

PR Author Checklist

PR Reviewer Checklist