CLIMADA-project / climada_python

Python (3.8+) version of CLIMADA
GNU General Public License v3.0
291 stars 115 forks source link

Make `cyclostrophic` a model parameter in the Holland windfield model interface #897

Open peanutfun opened 1 week ago

peanutfun commented 1 week ago

This follows-up on a discussion in https://github.com/CLIMADA-project/climada_python/pull/846#discussion_r1638297149.

Is your feature request related to a problem? Please describe. cyclostrophic is a parameter in all but the Holland 2010 windfield models. It is forced to False, but the Holland 2010 model is always cyclostrophic, and choosing False does not make sense here.

Describe the solution you'd like

  1. cyclostrophic should become a model_kwarg in TropCyclone.from_tracks. It should have a "variable" default: True for Holland 2010, False for all other models.
  2. Using cyclostrophic=False for Holland 2010 should result in an error.

Describe alternatives you've considered None

Additional context None

@ThomasRoosli