Open riley-brady opened 4 months ago
@riley-brady Thank you for your report. We do not observe this issue in our testing pipeline. As the test loads data from Excel and HDF5 files, the issue might be related to particularities of the involved libraries on your system.
Nonetheless, the test can be considered legacy because it does not follow our new unit test standards. I will therefore transform this issue into a task to rewrite the test, such that it does not rely on reading data.
@riley-brady What I forgot to mention: If this is the only failing test in your installation, I think you can safely ignore it for now ✌️
Thank you! Yes, agreed it does not impact use of climada
. I agree that it's likely library-dependent. I tried with and without bottleneck
installed, which didn't change anything. But I think it's a roundoff/precision issue related to something like that. Thanks!
Describe the bug Following the simple installation guide, the base unit tests currently fail (for a single test). This is a simple roundoff error failure for
test_local_exceedance_imp_pass
.To Reproduce Steps to reproduce the behavior/error:
mamba create -n climada_env -c conda-forge climada
mamba activate climada_env
python -m unittest climada.engine.test.test_impact
Expected behavior Tests should pass!
Climada Version: 4.1.0
System Information (please complete the following information):
Additional context
climada
. It persists withclimada-petals
installed.bottleneck
but this didn't do the trick. I've found in the past thatbottleneck
can lead to roundoff level issues (https://github.com/pydata/xarray/issues/1346, https://github.com/pydata/xarray/issues/7344).