search

CLIP-HPC / goslmailer

GoSlurmMailer - drop in replacement for default slurm MailProg. Delivers slurm job messages to various destinations.
40 stars 6 forks source link

21 feature request mattermost #22

Closed pja237 closed 1 year ago

pja237 commented 1 year ago

Mattermost connector and bot prototype.

pja237 commented 1 year ago

:+1: agree, even without the #15 change, we should do it anyways. It'll save a lot of time/errors when developing future stuff. Only reason this is not so is because it all started with legacy mail conn, when i thought it doesn't need spooling, then matrix again we did without spooling, both with no real reason why, except perhaps laziness/shortcutting :angel: :laughing: There is no good reason why all connectors wouldn't have the same spooling/lookup/rendering harness code in a separate package, and the SendMessage() registered by the connector code only does this tiny part (e.g. from this conn): https://github.com/CLIP-HPC/goslmailer/blob/12ccfe051c3f1c8d3ab24fe599e6c7ba767087ab/connectors/mattermost/mattermost.go#L107-L122

The only question left is then, leave the #15 as is, and with it users still have the option to run goslmailer only, or force gobler on everyone....