search

CLMBRs / modal-typology

0 stars 5 forks source link

Vietnamese data pull request #22

Closed JamesE6 closed 1 year ago

JamesE6 commented 1 year ago

Adding a modals csv and metadata yaml for Vietnamese, for review by Shane and Qingxia.

wigwit commented 1 year ago

Hi James, great work! I really appreciate your effort into transforming the data in such a short time period. And sorry about my delayed response! Just some small comments about the annotation for negation. The expression được in negative context is treated as separate expression (NEG+ được). I think it would be better to put them under the same expression (được) and specify the form under full_form, you can take a look at this link [https://docs.google.com/spreadsheets/d/1_PuX70AlfL8J_R9n3Y9DA0soUZEPiIUSLsRLXi_ZI7A/edit#gid=0] under Tlingit from row 26-37, both positive and negative contexts are under the same expression "future mode". And another small tips, there are two separate expressions (được) that are written as the same, you made distinction by calling them được1 and được2. You can include the choice you made in the notes in modals.csv, or create a readme.md in the language folder.

wigwit commented 1 year ago

nice work! Thanks!