Topic mapping conflict not showing in Map view until try to remove the topic

CLOSER-Cohorts / archivist

Archivist is designed to be an easy to use editor that allows documention of questionnaires and data in DDI-Lifecycle

MIT License

18 stars 8 forks source link

Topic mapping conflict not showing in Map view until try to remove the topic #859

Closed HayleyMills closed 3 months ago

HayleyMills commented 5 months ago

I know there is a conflict as it showed in the import mapping pages when I uploaded the tv.txt file, but didn't show in the map view, which is an issue.

Clicked x to remove finances and it saves

But then reverts back to finances and then does show an error, which should have been there before, but not after I removed the topic

I will try to resolve using the .txt files, and so will need to replicate on staging.

simonreed commented 4 months ago

@HayleyMills this will now show the validation error when you go to the instrument mapping page and there is a conflict, you no longer need to make a change to see it. This is on staging.

HayleyMills commented 3 months ago

Tested on staging, and the conflict error is appearing, when I click the x, the conflict is resolved as expected.

HayleyMills commented 3 months ago

Re-tested on another instrument, and it is not working as expected. https://closer-archivist-staging.herokuapp.com/admin/datasets/805/imports/1344

No conflict is shown on the variable view

No conflict is shown on map view https://closer-archivist-staging.herokuapp.com/instruments/mcs2_new/map/

Clicked the x and no topic is assigned

simonreed commented 3 months ago

There is no conflict shown on https://closer-archivist-staging.herokuapp.com/instruments/mcs2_new/map/ because the conflict was caught as part of the import. We now don't save the topic if there's a conflict so when you visit the map page there is no conflict in this case to show.

HayleyMills commented 3 months ago

Ok, I will make a note of this in the documentation, so we know this is the behaviour.