search

CLOVER-energy / CLOVER

CLOVER minigrid simulation and optimisation for supporting rural electrification in developing countries
MIT License
17 stars 3 forks source link

Diesel fuel costs uses first-day usage #222

Closed BenWinchester closed 1 year ago

BenWinchester commented 1 year ago

Describe the bug

Element-wise multiplication is potentially producing a bug where the diesel fuel usage for the first day is used to compute the diesel costs, rather than the usage throughout the simulations.

To Reproduce

Steps to reproduce the behavior:

  1. Insert a breakpoint in line 845 of finance.py,
  2. Run CLOVER, with either --simulation --analyse or --optimisation to cause the appraisal function to run
  3. Investigate the diesel_costs object,
  4. See error

Expected behaviour

Further investigation is required by the @CLOVER-energy/clover-development-team , but, potentially, the diagonal of the current object should be used.

Screenshots

image

Additional Information

Desktop

Modifications

Modifications have been made to the code on the Harry branch.

BenWinchester commented 1 year ago

@CLOVER-energy/clover-development-team , check whether this affects the GHG file as well due to diesel-fuel GHGs 😄