search

CMA-ES / c-cmaes

CMA-ES written in ANSI C (yet fairly object-oriented)
Other
56 stars 26 forks source link

boundary_transformation() functions not prefixed with cmaes_ #5

Open sherm1 opened 10 years ago

sherm1 commented 10 years ago

Hi, Niko. While incorporating cma-es into Simbody, we noticed some external functions boundary_transformation() etc. that don't have the usual cmaes_ prefix so would potentially cause link-time conflicts for our users. @chrisdembia removed those files from our port for now, but I would like to be able to include the whole package unchanged to facilitate later updating, and in case someone wants to take advantage of those functions later. Please prefix all the extern functions if possible.

Sherm

nikohansen commented 9 years ago

I am somewhat hesitating to prefix the boundary functions with cmaes_, because they are entirely unrelated to the optimization method used. I see the point though to have the module source explicitly given to reduce the possibility of name clashes.

sherm1 commented 9 years ago

I see your point. And these are all prefixed by boundary_ already -- my only worry is that that prefix is a little too generic so someone else might reasonably use the same one. But that's a hypothetical concern at this point. We are not linking in those functions at the moment so we don't have a problem.