Extern functions in cmaes.c with prefixes other than 'cmaes_'

CMA-ES / c-cmaes

CMA-ES written in ANSI C (yet fairly object-oriented)

Other

56 stars 26 forks source link

Extern functions in cmaes.c with prefixes other than 'cmaes_' #7

Closed chrisdembia closed 9 years ago

chrisdembia commented 9 years ago

We are making good progress incorporating cmaes into simbody; see https://github.com/simbody/simbody/pull/253.

Currently, there are a few extern functions in cmaes.c (e.g., random_*). Can these be named with a cmaes_ prefix, or otherwise be placed under local visiblity?

If you'd like, I could submit a pull request for the change, but @sherm1 and I would like to know what you think.

nikohansen commented 9 years ago

For the moment I don't see a reason why they should not get the cmaes_ prefix . Don't hesitate to submit a pull request.