Closed nikohansen closed 9 years ago
Yes, this is because you may want to create a branch with your fixes on your repo and PR that branch. Otherwise github detects it as an addition to an existing PR. Basically a PR can be understood and defined by two endpoints, yours and that to which you'd like your code to be integrated.
I don't believe it matters too much just now for this one, and I'll try to use it as is.
FYI, I don't believe it matters too much as the plot looks fine but I get this error warning:
/usr/lib/pymodules/python2.7/matplotlib/scale.py:90: RuntimeWarning: invalid value encountered in less_equal
mask = a <= 0.0
I believe this is unrelated to the changes in cma_multiplt.py
.
EDIT: I believe it happens when trying to log-plot non-positive numbers.
OK, this has been merged.
Ah, just a thingy, when doing PR, it is best to do them against 'dev' branch. In this particular case it didn't matter though.
I don't exactly understand why we see the commits from 2014 here, I just meant to push those from Feb 12, 2015.