search

CMAP-REPOS / cmapgeo

R-friendly geodata for the Chicago region
https://cmap-repos.github.io/cmapgeo/
Other
7 stars 0 forks source link

Revert "Merge pull request #15 from CMAP-REPOS/workflow_versions" #16

Closed EthanJantz closed 10 months ago

EthanJantz commented 1 year ago

This reverts commit 460f36c03b598d78cf7e329f47fb5092a3a6572a, reversing changes made to 90266fa410427f4c50e66da258f9872a5a9ac487. The previous merge broke our pkgdown and R-CMD-check workflows.

dlcomeaux commented 1 year ago

Huh, @EthanJantz any idea what happened? IIRC the checks passed when we did them. These aren't urgent changes, just areas where it seemed like our version numbers were out of date. As I've talked with you about, I'm not super-familiar with the inner details of these workflows, so, if we need to do something else, that's OK with me.

dlcomeaux commented 1 year ago

Hmm. Still failing. It seems like the issue is not with checkout or any of those, but with the Census API. It is showing this error:

Run tidycensus::census_api_key(Sys.getenv("CENSUS_API_KEY"), install = TRUE) Error in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]) : there is no package called ‘sf’ Calls: loadNamespace ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart Execution halted Error: Process completed with exit code 1.

EthanJantz commented 1 year ago

That's the same error that came up when I merged the previous PR. It looks like the windows-latest workflow ran fine on this PR, but not he macOS-latest version. I spent some time this morning looking for the location of our API key on this repository but could not find it. @nmpeterson Do you know how to locate the secrets file?

nmpeterson commented 1 year ago

When I left, I think I transferred it from a personal secret in my account to a CMAP-REPOS org secret. You'll need to ask @amcadamsCMAP (or any CMAP-REPOS admin) to investigate.