search

CMB-S4 / s4sim

Simulation tools
1 stars 1 forks source link

Data Challenge 0 Updates #26

Closed smsimon closed 1 year ago

smsimon commented 1 year ago

Updates to the instrument model for DC0 runs.

jdborrill commented 1 year ago

That's almost certainly wrong, and if it's not wrong it is horribly mis-named.

We should be using the just-frozen PBD instrument model from Sara.

Julian

On Fri, Apr 28, 2023 at 8:45 AM Andrea Zonca @.***> wrote:

@.**** commented on this pull request.

In s4sim/hardware/config.py https://github.com/CMB-S4/s4sim/pull/26#discussion_r1180566643:

 tele["fwhm"] = lfwhm

telescopes["LAT2"] = tele

 #from the DSR
 sfwhm = OrderedDict()
  • sfwhm["SAT_f030"] = 72.8
  • sfwhm["SAT_f040"] = 72.8
  • sfwhm["SAT_f085"] = 25.5
  • sfwhm["SAT_f145"] = 25.5
  • sfwhm["SAT_f095"] = 22.7
  • sfwhm["SAT_f155"] = 22.7
  • sfwhm["SAT_f220"] = 13.0
  • sfwhm["SAT_f280"] = 13.0
  • sfwhm["SAT_f030"] = 85.2

I used https://github.com/CMB-S4/s4mapbasedsims/blob/master/202102_design_tool_run/instrument_model/cmbs4_instrument_model.tbl

— Reply to this email directly, view it on GitHub https://github.com/CMB-S4/s4sim/pull/26#discussion_r1180566643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4LSWP4YUKDKH4LY5TQVLXDPQYNANCNFSM6AAAAAAVO747X4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tskisner commented 1 year ago

The changes in this DC0 branch were implemented in #30, checked by @smsimon , and are now merged into master. I suggest we delete this PR and open a new PR against master to address any lingering issues.

smsimon commented 1 year ago

Agreed