CMB / edbrowse

A command-line editor and web browser.
Other
345 stars 31 forks source link

Split QUICKJS_DIR #88

Closed alfonsosiciliano closed 1 year ago

alfonsosiciliano commented 1 year ago

Hello,

src/makefile provides the QUICKJS_DIR variable to set the directory of quickjs after a git clone.

If possible I would split: QUICKJS_DIR to QUICKJS_INCLUDE and QUICKJS_LIB because several OSs divide include and lib directories. Of course my diff with: QUICKJS_INCLUDE ?= ../../quickjs QUICKJS_LIB ?= ../../quickjs ensures that the current build process is still possible "download quickjs in a directory adjacent to edbrowse". Instead we Distro/OS maintainers can set and pass the new variables avoiding to patch src/makefile.

I hope my explanation is understandable. Alfonso