search

CMDR-Kiel42 / EDMC_SpanshRouter

A plugin for EDMC to make your life easier when using Spansh
45 stars 17 forks source link

stop working with EDMC release 5.8.0 #34

Open taloche1 opened 1 year ago

taloche1 commented 1 year ago

Hi ,

plugin spanishrouter 3.1.0 don't start with new release EDMC 5.8.0. They made some change in UI and parent object access.

I use your plugin and it is very usfull to play elite dangerous in VR.

If i can help.

taloche1 commented 1 year ago

Hi again. I fix the trouble by declare tk.Frame in plugin_app, pass it to spanish router class and return it in plugin_app. I don't know how to transfert here the modified code, and maybe my solution is not optimal but working. i see the gui now.

taloche1 commented 1 year ago

also need change in show_plot_gui line self.source_ac.set_text(monitor.system if monitor.system is not None else "Source System", monitor.system is None) i think monitor.system is probleme source.

Kumdanadam commented 1 year ago

any progress with this current ui issue?

Xariss00 commented 1 year ago

It looks like @taloche1 was able to fix the issue for themselves, but I have no idea how to implement their fix for everyone, or even just myself. :(

GitKageHub commented 1 year ago

@taloche1 if you can email me the code I can help facilitate getting it in here for you. Please make contact here or on Discord @ https://discord.gg/muQqDCVpMf

taloche1 commented 1 year ago

load.zip

GitKageHub commented 1 year ago

load.zip

Pull request #35 created, you are tagged as co-author (it's kind of the limitation since I'm committing on your behalf).

GitKageHub commented 1 year ago

any progress with this current ui issue?

https://github.com/CMDR-Kiel42/EDMC_SpanshRouter/pull/35

taloche1 commented 1 year ago

you forgot to put SpanshRouter.py in your #35 ....

GitKageHub commented 1 year ago

you forgot to put SpanshRouter.py in your #35 ....

Files changed: 2: SpanshRouter/SpanshRouter.py and load.py https://github.com/CMDR-Kiel42/EDMC_SpanshRouter/pull/35/files

Comment on #35 if you want to discuss the request – these are the files you sent me as you sent them.

jhaprins commented 1 year ago

Looking at the pull request, it looks to me like the code is created on an older version of the plugin and then applied to the new code version or something. Maybe someone needs to look at the needed changes and create a pull request against the latest version of the code.

GitKageHub commented 1 year ago

Looking at the pull request, it looks to me like the code is created on an older version of the plugin and then applied to the new code version or something. Maybe someone needs to look at the needed changes and create a pull request against the latest version of the code.

I may get time soon to actually sit down and sort out the changes that helped restore the functionality and maybe even modernize it. I'll do what I can when I can but no promises rn.

XenHat commented 1 year ago

Tried using this today, got very confused that it doesn't work and found this issue. I would appreciate an update.

EDIT: source repo from the above pull request works.

Xariss00 commented 1 year ago

Tried using this today, got very confused that it doesn't work and found this issue. I would appreciate an update.

EDIT: source repo from the above pull request works.

Sort of - the workaround @taloche1 came up with restores limited functionality, i.e. you can import a pre-made route; however, you are still unable to plot a new route (neutron, FC, etc.) from directly within EDMC.

Still definitely better than nothing, though. :-)

taloche1 commented 1 year ago

hi, the two problems are solve. see the zip file. you have two file, remplace eatch and that work, including plot route. The no solve issu in to initiate the system from where you are, in the begining of plot route process, but copy past work fine. So replace th 2 files, not the first one.