search

CMDR-Kiel42 / EDMC_SpanshRouter

A plugin for EDMC to make your life easier when using Spansh
45 stars 17 forks source link

Bug Fix #35

Closed GitKageHub closed 9 months ago

GitKageHub commented 1 year ago

This code resolves the current issue with the buttons not displaying on the EDMC. I'm currently just facilitating this while I am independently studying Python and can't comment to the large number of deletions. @CMDR-Kiel42 please evaluate the SpanshRouter/SpanshRouter.py thoroughly before committing to Master, but the load.py looks spot-on.

jmyoung commented 1 year ago

Pulled the repo posted by GitKageHub and put it into my EDMC client (latest version). Appears to work fine, I get Spansh functionality again, yay!

XenHat commented 1 year ago

Confirming this works for me too.

mdmallardi commented 1 year ago

Hi, I've opened a PR on gitkagehub's branch that forward ports this fix up to Kiel's latest master. -- It looked as though this original patch was written against Kiel's master three commits back, which was the cause of the feature and code deletion.

https://github.com/GitKageHub/EDMC_SpanshRouter/pull/1

I've not tested it beyond loading EDMC and seeing that the SpanshRouter plugin loads and displays its UI.