CMPUT301F18T16 / Baudit

A health auditing application
https://cmput301f18t16.github.io/Baudit/
MIT License
0 stars 0 forks source link

ProblemPresenter and RecordPresenter final patch hopefully #221

Closed dcones closed 5 years ago

dcones commented 5 years ago

Got rid of AddRecord button on ProblemActivity to avoid the committing records without committing a problem issue

added hints AGAIN

fixed bug where the year would be set to currentYear - 1900 (Calendar is deprecated)

there's a known bug though, where if you Edit a Problem, and change the time/title/description and enter a problem view (add/edit), the changes to the problem will be lost upon returning to ProblemActivity

codecov[bot] commented 5 years ago

Codecov Report

Merging #221 into master will decrease coverage by 0.14%. The diff coverage is 29.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   52.13%   51.99%   -0.15%     
==========================================
  Files          57       57              
  Lines        2129     2131       +2     
  Branches      125      123       -2     
==========================================
- Hits         1110     1108       -2     
- Misses        962      966       +4     
  Partials       57       57
Flag Coverage Δ
#instrumentation 47.39% <29.72%> (-0.24%) :arrow_down:
#unit 10.51% <0%> (-0.01%) :arrow_down:
Impacted Files Coverage Δ
...ca/klapstein/baudit/activities/RecordActivity.java 38.98% <ø> (-4.72%) :arrow_down:
...a/klapstein/baudit/presenters/RecordPresenter.java 41.66% <0%> (-3.08%) :arrow_down:
.../klapstein/baudit/presenters/ProblemPresenter.java 35.18% <23.07%> (+3.81%) :arrow_up:
...a/klapstein/baudit/activities/ProblemActivity.java 41.91% <38.09%> (+1.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5dbdda...6be1f36. Read the comment docs.