Habits

[PaoVal]

Alright buckle up, this is a big PR.

This PR deals with:

• Showing daily list of habits - resolves #24
• Showing list of all habits - there is no dedicated issue to this, it's included in #24
• Showing detailed view of habits - resolves #13 since some ui changes were necessary and resolves #95 which populates the data
• Adding habits - resolves #6, and also #20 since some error checking was performed to ensure user input is correct
• Editing habits - resolves #14, saves edited data on the database
• Deleting habits - resolves #17

Things I modified duringx merge conflict:

• getHabitDays in the progress file was modified to fit with what the data on the database will actually look like.
• Modified getAllHabits (this was already implemented, I believe. Do let me know if it does anything new that the already existing functions don't)
• getHabit and setHabit in HabitViewActivity were deleted. I don't see them ever being used.

[NickSNFK]

I added a couple of comments. I am not done reviewing yet. I was trying to test your code on AndroidStudio. The DatabaseManager is throwing errors because you changed the constructor of Habit.

This because there is a new field in the Habit Class (titleDisplay), can we get this updated in the database manager?

[PaoVal]

I added a couple of comments. I am not done reviewing yet. I was trying to test your code on AndroidStudio. The DatabaseManager is throwing errors because you changed the constructor of Habit.

I am assuming this is not an issue anymore @zarifmahfuz ?

[PaoVal]

@zarifmahfuz

When I click on “Edit”, the fragment fields are not pre-filled by the original details. This makes things harder for the user. We must address this in the future.

I was planning on doing this but ran out of time. Also, once again, having the same fragment for adding and editing really restricts what you can do here. I suggested changing this a while back to no avail. And now there is no time to do so. Maybe for the next deliverable

Since John is using the key of a habit to display habit titles on his habit events screen, the change made by editing the habit title does not get reflected on his screen. This is something we need to address in the future.

Tried to fix this but will take more than I thought. SO I suggest we push this back to the next deliverable.

[zarifmahfuz]

comments. I am n

Correct

[NickSNFK]

Would the changes in Habit.java class affect getAllHabits method in DatabaseManager class? I'm using the method to get all Habit titles. If not then it's good to merge.

I believe @PaoVal changed it already

[PaoVal]

Would the changes in Habit.java class affect getAllHabits method in DatabaseManager class? I'm using the method to get all Habit titles. If not then it's good to merge.

I made some changes there so we have getAllHabits separate from what I made.

I think we should only have one function for this in the future. Though it works as implemented right now.

[PaoVal]

I am going to merge this since everyone seems ok with it