Habit event testing, feedback, bug fixing and UI updates + image upload/display

johnzhang27 commented 2 years ago

This PR is related the following issues:

159 Habit event list now is launched from a given habit detail view and it only display the habit event associated with the selected habit.
158 Since we need more space to display details of a habit event (image, comment), the fragment has been converted to an activity.
164 Use toast to display feedback messages after user add/edit/delete a habit event.
165 Use custom intent testing rule created by @zarifmahfuz to re-write intent tests related to habit event.
166 Merged image upload/display function created by @Jie-F to the newest habit event UI. @Jie-F needs to add some javadoc for image upload/display functions.
167 Use a snapshot listener in HabitEventList Activity instead of getAllHabitEvents function. Have to do this because of an asynchronous error.

close #159 close #158 close #164 close #165 close #166 close #167

PaoVal commented 2 years ago

Looks generally good. I tested it and ran into no problems. So I'd say to go ahead. Please just push the UI changes you shared with the team before. And then I'd say good to go! (Only actual thing is to please comment the event detail activity. I don't see any javadoc there, or it might also be GitHub bugging out again)

johnzhang27 commented 2 years ago

Looks generally good. I tested it and ran into no problems. So I'd say to go ahead. Please just push the UI changes you shared with the team before. And then I'd say good to go! (Only actual thing is to please comment the event detail activity. I don't see any javadoc there, or it might also be GitHub bugging out again)

New changes has been pushed, check commit #4d6dc5e

CMPUT301F21T23 / HabitTracker

Habit event testing, feedback, bug fixing and UI updates + image upload/display #168

159 Habit event list now is launched from a given habit detail view and it only display the habit event associated with the selected habit.

158 Since we need more space to display details of a habit event (image, comment), the fragment has been converted to an activity.

164 Use toast to display feedback messages after user add/edit/delete a habit event.

165 Use custom intent testing rule created by @zarifmahfuz to re-write intent tests related to habit event.

166 Merged image upload/display function created by @Jie-F to the newest habit event UI. @Jie-F needs to add some javadoc for image upload/display functions.

167 Use a snapshot listener in HabitEventList Activity instead of getAllHabitEvents function. Have to do this because of an asynchronous error.