search

CMPUT301F23T01 / Sigma-Blue

Introduction to Software engineering project repository
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Bach/feature/filter date #179

Closed waridh closed 10 months ago

waridh commented 10 months ago

done adding the filter date feature. There is room for refactoring. I would like to do those refactors myself after tags has been implemented.

waridh commented 10 months ago

Why do we need Quadruple. This is actually redundant

Should I nest pairs twice, or use an arraylist? Like, I just need to store four things in order, like a tuple, but java doesn't have a nice tuple implementation.

bpaul2 commented 10 months ago

Just use an arraylist or a flat out array. This is definately not the case where we need this kind of class

bpaul2 commented 10 months ago

THe fact that the pair class exists as well is also an issue

waridh commented 10 months ago

You tell me how I contain three different type in the same data structure without making a generic container like these.

waridh commented 10 months ago

These aren't issues, I made these structs because we needed it. Would you rather I inline the struct and make four setters for each of them?

waridh commented 10 months ago

Typecasts out of an object array? Object arraylist? These should not be solved via inheritance. They needed generics.

lizard-52 commented 10 months ago

I'm making a PR to remove Pair, removing quad should be similar.

waridh commented 10 months ago

We need to talk. Are you coming to class?

lizard-52 commented 10 months ago

Making another PR on a different branch. The merging was super confusing and I had to resort to copy-paste.