CMPUT301F23T01 / Sigma-Blue

Introduction to Software engineering project repository
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

UI Add/Edit Changes #191

Closed bpaul2 closed 10 months ago

bpaul2 commented 10 months ago

This implements tabs partitioning for the EditFragment. Next part will include the DetailsFragment.

bpaul2 commented 10 months ago

This now includes support for the details section

lizard-52 commented 10 months ago

Hitting the back button from the gallery causes a crash

waridh commented 10 months ago

Hitting the back button from the gallery causes a crash

Wait, is this still an issue?

lizard-52 commented 10 months ago

Working on a fix now

waridh commented 10 months ago

Hi, here is a ux interaction that I found. In the add page, if the user has not input a make and model, they cannot view the tags page. I don't really think that we have time to solve this one before the due date (or even if we did, we should focus on other things, my time estimation doesn't think it should be done). This comment is really just a note for the presentation.

waridh commented 10 months ago

Another testing item that I just did that may or may not be an issue? When I try to add a tag, and press the color? button, and nothing shows up. If I press save, it will crash the app.

waridh commented 10 months ago

Another testing item that I just did that may or may not be an issue? When I try to add a tag, and press the color? button, and nothing shows up. If I press save, it will crash the app.

Actually, not just crash the app. It puts me in the backroom.

image

Edit 1:

After relogging in, the tag has been created, but the item that was being logged did not get saved.

Edit 2:

Other than the above issues, I didn't find anything else wrong with it.

Edit 3:

This issue is in main. It's when you are trying to add a new tag when you are in add item page

lizard-52 commented 10 months ago

@waridh Since it's a problem in main too can you approve this PR? I'll make another for the bug fix.

waridh commented 10 months ago

@waridh Since it's a problem in main too can you approve this PR? I'll make another for the bug fix.

yes