search

CMPUT301F23T01 / Sigma-Blue

Introduction to Software engineering project repository
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Nikolai/feature/search #192

Closed lizard-52 closed 10 months ago

lizard-52 commented 10 months ago

Re implement the search function. Searches are case insensitive and will match any item with the search string contained in the name/make/description field.

Sorting works too.

waridh commented 10 months ago

Actually, why did we remove the unsorted state? It was implicitly sort by oldest entry.

lizard-52 commented 10 months ago

Actually, why did we remove the unsorted state? It was implicitly sort by oldest entry.

I figured an 'unsorted' state doesn't really make sense since the list is always sorted. It's set up to be easy to change the default, you just need to change the constructor in ItemSortComparator.

waridh commented 10 months ago

So it looks like date query is not fully fixed. The UI restoration is correct, but the search is wrong. Also, when I had the wrong date query selected and then selected reset query, the app crashes.

waridh commented 10 months ago

So it looks like date query is not fully fixed. The UI restoration is correct, but the search is wrong. Also, when I had the wrong date query selected and then selected reset query, the app crashes.

To be specific, the ui will now start in the correct month, but we would still need to query in october to get november items. The app crashing on reset button one seems new though.

lizard-52 commented 10 months ago

Ok don't tell anyone, but I didn't actually test that last fix. It should be working now