search

CMPUT301W13T06 / classproject

RecipeBot
http://cmput301w13t06.github.com/classproject/
2 stars 6 forks source link

Brianmerged #32

Closed gptrinh closed 11 years ago

gptrinh commented 11 years ago
f2prateek commented 11 years ago

Hey Brian, just a couple of things to keep in mind.

  1. AddRecipe should extends BaseActivity
  2. AddRecipe should be named AddRecipe Activity.
  3. Tests for AddRecipe - be sure to add some tests, so when we commit stuff we won't break your functionality.

I'll fix these today if I have the time.

saturna commented 11 years ago

Hey Prateek, just an update, I managed to make the database and these methods functional:

add pantry item remove pantry item load pantry remove recipe add recipe load recipes

The only feature I'm still working on is edit recipe, right after I'm done with the database I will get on updating our UML

Thanks, Adam

On Mon, Mar 11, 2013 at 10:24 AM, Prateek Srivastava < notifications@github.com> wrote:

Hey Brian, just a couple of things to keep in mind.

  1. The main activity should MainActivity, not the AddRecipe class
  2. AddRecipe should extends BaseActivity
  3. AddRecipe should be named AddRecipe Activity.

I'll fix these today if I have the time.

— Reply to this email directly or view it on GitHubhttps://github.com/CMPUT301W13T06/classproject/pull/32#issuecomment-14723230 .

saturna commented 11 years ago

Hey Prateek, is it fine if Edit recipe method is broken down into : editRecipeName, EditRecipePrep, EditRecipePictures, and EditRecipeIngredients? I think it will be faster in practice, that way we avoid unnecessary update calls on the stuff that isn't getting updated?

On Mon, Mar 11, 2013 at 10:24 AM, Prateek Srivastava < notifications@github.com> wrote:

Hey Brian, just a couple of things to keep in mind.

  1. The main activity should MainActivity, not the AddRecipe class
  2. AddRecipe should extends BaseActivity
  3. AddRecipe should be named AddRecipe Activity.

I'll fix these today if I have the time.

— Reply to this email directly or view it on GitHubhttps://github.com/CMPUT301W13T06/classproject/pull/32#issuecomment-14723230 .

f2prateek commented 11 years ago

Sounds like a good idea. On Mar 11, 2013 11:04 AM, "saturna" notifications@github.com wrote:

Hey Prateek, is it fine if Edit recipe method is broken down into : editRecipeName, EditRecipePrep, EditRecipePictures, and EditRecipeIngredients? I think it will be faster in practice, that way we avoid unnecessary update calls on the stuff that isn't getting updated?

On Mon, Mar 11, 2013 at 10:24 AM, Prateek Srivastava < notifications@github.com> wrote:

Hey Brian, just a couple of things to keep in mind.

  1. The main activity should MainActivity, not the AddRecipe class
  2. AddRecipe should extends BaseActivity
  3. AddRecipe should be named AddRecipe Activity.

I'll fix these today if I have the time.

— Reply to this email directly or view it on GitHub< https://github.com/CMPUT301W13T06/classproject/pull/32#issuecomment-14723230>

.

— Reply to this email directly or view it on GitHubhttps://github.com/CMPUT301W13T06/classproject/pull/32#issuecomment-14725837 .

f2prateek commented 11 years ago

If you're adding the UML, just link to this post https://github.com/CMPUT301W13T06/classproject/issues/21 - the wiki points to that for our UML.

saturna commented 11 years ago

Sounds good, working on it ATM

On Mon, Mar 11, 2013 at 12:23 PM, Prateek Srivastava < notifications@github.com> wrote:

If you're adding the UML, just link to this post #21https://github.com/CMPUT301W13T06/classproject/issues/21- the wiki points to that for our UML.

— Reply to this email directly or view it on GitHubhttps://github.com/CMPUT301W13T06/classproject/pull/32#issuecomment-14730973 .

f2prateek commented 11 years ago

Hey @btrinh1 , we're going to have to revert this commit - GridLayout is new in API 14, so it doesn't work for before that. I'll leave it in for the part 3, but we'll have to use some other UI widgets.

https://developer.android.com/reference/android/widget/GridLayout.html

f2prateek commented 11 years ago

https://travis-ci.org/CMPUT301W13T06/classproject/builds/5417853