search

CMPUT301W13T06 / classproject

RecipeBot
http://cmput301w13t06.github.com/classproject/
2 stars 6 forks source link

Pantry fragment #39

Closed ethanmykytiuk closed 11 years ago

ethanmykytiuk commented 11 years ago

Trying this again to see if it works this time

f2prateek commented 11 years ago

Seems good. merge it if its good for the demo.

ethanmykytiuk commented 11 years ago

Merging pantry-fragment to development branch

f2prateek commented 11 years ago

Hey @ethanmykytiuk , this actually fails the build. I'll be reverting this change along with #32. - https://travis-ci.org/CMPUT301W13T06/classproject/jobs/5421198

Sorry for not catching this earlier, I checked this from my phone, and I didn't notice that the build fails.

ethanmykytiuk commented 11 years ago

Alright, so if I just created the view inside the OnCreate method then it should work and avoid the NPE?

f2prateek commented 11 years ago

For fragments you can't do it on onCreate. The fragment must supply the view in the onCreateView method.

ethanmykytiuk commented 11 years ago

Alright, I had it two different ways but I commented out the second one. If you are in class tomorrow I'll show you the other code and see if it will work

f2prateek commented 11 years ago

Sure sounds good. On Mar 12, 2013 11:21 PM, "ethanmykytiuk" notifications@github.com wrote:

Alright, I had it two different ways but I commented out the second one. If you are in class tomorrow I'll show you the other code and see if it will work

— Reply to this email directly or view it on GitHubhttps://github.com/CMPUT301W13T06/classproject/pull/39#issuecomment-14825062 .

f2prateek commented 11 years ago

Can you actually test that other code and and see if it works? Then we can maybe try to get have it accepted for the Part 3 code.