search

CMPUT301W14T04 / Team04Project

Other
0 stars 3 forks source link

Comment ID #19

Open nyushko opened 10 years ago

nyushko commented 10 years ago

Hey, I need the comment ID to be able to edit individual comments. I have been spending some time trying to add it to a hidden textview inside comment_row but it keeps giving me an error. I added the getters and setters in the Commentor and Comment objects but I keep getting a duplicate key error when the JSON is parsed. If you can please help me out with that, that would really help me out with finishing the code for edit comments. Thanks

gramirezualberta commented 10 years ago

hey i don't see why you need the comment ID to edit the text, you just use comment ID to update the comment in elasticsearch. what do you mean with duplicate key error?

nyushko commented 10 years ago

Just like you said, to update the comment in elasticsearch. Once you edit the comment I need to post it to the server to update that comments entry.To find the entry I need the unique identifier to look it up in the server data. duplicate key error because I'm guessing there is already a call to get the comment ID, but I created another variable to get the comment ID. I just can't find the one you used

gramirezualberta commented 10 years ago

are you calling ElasticsearchOperation.push? because that could be the problem.

nyushko commented 10 years ago

I don't need to do a push on the whole thing tho, I need to just find the specific comment by comment ID and then find the comment text to exchange it. How do you get the comment ID?

gramirezualberta commented 10 years ago

hey, i changes the code now, the id in elasticserach is the same as the comment ID, also add a getID in commentor to get the comment id. I feixed a bug where when you create a new toplevel comment was pushing into reply instead of top level. I hope this solve your problem

nyushko commented 10 years ago

When you.add a comment, is it recreating the string? Or is it just appending to the string of all the comments On Mar 29, 2014 7:32 PM, "gramirezualberta" notifications@github.com wrote:

hey, i changes the code now, the id in elasticserach is the same as the comment ID, also add a getID in commentor to get the comment id. I feixed a bug where when you create a new toplevel comment was pushing into reply instead of top level. I hope this solve your problem

Reply to this email directly or view it on GitHubhttps://github.com/CMPUT301W14T04/Team04Project/issues/19#issuecomment-39014837 .