search

CMPUT301W14T04 / Team04Project

Other
0 stars 3 forks source link

Who keeps taking the menu button off #21

Open nyushko opened 10 years ago

nyushko commented 10 years ago

The three vertical dots that show settings, create new comment and now the refresh button. I added it back on Thursday b/c it was gone and it's been deleted again. Is there a particular reason someone keeps taking it off?

telbohtimy commented 10 years ago

Strange it's been there for me the whole time

nyushko commented 10 years ago

it's there right now? I just pulled a version off git

telbohtimy commented 10 years ago

The menu is there but instead of doing settings it keeps refreshing instead.

telbohtimy commented 10 years ago

I just cloned off of github

nyushko commented 10 years ago

here is what is going on on mine. all the buttons do what they are supposed to do. i added in the menu bar. i get the correct toast message for all of them too. the problem is i can't create a comment without logging in and I can't reach the login view because i keep getting a location error, that no location exists. setting the location manually doesn't work either. Please tell me someone else is having exactly the same issue

gramirezualberta commented 10 years ago

does location error is shown in the console or is a Toast message?

gramirezualberta commented 10 years ago

I fixed the setting and refresh problem, also what exactly the location error are you getting?

nyushko commented 10 years ago

What was the error on refresh? it's working fine on mine. Anyway the location error is in the log

gramirezualberta commented 10 years ago

the problem was if you press settings, the app call refresh instead of go to the settings activity. could you give me more info about the location error?

nyushko commented 10 years ago

how is it possible for both me and Tarek to do a pull off git at the same time and for the settings to be fine on mine, and not fine on his? Ok I'm going to try to figure this out, obviously it's just my computer

gramirezualberta commented 10 years ago

Well the thing is that when you call git pull, it will get the update from github and merge that with your change you had done, but you had not pushed yet. So, i'm assuming that the code tarek has and your code is different in the some point.

you can look more in here: http://stackoverflow.com/questions/292357/whats-the-difference-between-git-pull-and-git-fetch