search

CMPUT301W15T03 / Team3ScandalouStopwatch

CMPUT301 TEAM CMPUT301W15T3 Git Repository
Apache License 2.0
0 stars 0 forks source link

Claim status changes and canEdit #13

Closed ghost closed 9 years ago

ghost commented 9 years ago

When submitting, approving or returning a claim, it might be better if the canEdit flag isn't passed as a parameter from the activity through the controller and finally to the claim model. Since whether a claim is editable is ultimately a model issue, the claim itself should make that decision.

cchomyc commented 9 years ago

I removed status and canEdit from submitting, approving, and returning. CanEdit is purely dependant on the status and shouldn't be set seperately. We could refactor the model, but that's fairly intensive so I don't know if anyone wants to do that.