search

CMPUT301W15T12 / C301Project

Apache License 2.0
3 stars 2 forks source link

Integrated online photo saving #84

Closed qsjiang closed 9 years ago

qsjiang commented 9 years ago

Hi @megsum,

I just integrated the photo saving, so far it works fine, but there are quite a lot of stuffs going on inside additemActivity class. I figured it's best to ask the original author to take a look.

Here is the commit with all the related changes fbe692fe07195d8b7864bfe3796096cc0839a076

I am free tomorrow after 1pm. If you have time we should meet and go over the changes.

megsum commented 9 years ago

Okay sounds good! I will look at it now!

qsjiang commented 9 years ago

@megsum cool

megsum commented 9 years ago

@qsjiang I am not too sure how the client stuff works, but it looks like you changed where it needs to be changed! From what I can see it makes a temporary location that stores the photo and then uploads it to the server from there. If so it looks good!

qsjiang commented 9 years ago

ya. The previous Uri saved inside expenseItem was just a local file pointer. Now it's a relative path on the elastic server. The temp uri is just a temp location for saving the output from the camera app.

vanbelle commented 9 years ago

I'm getting an error in the one of the photo tests now, don't forget to update that so it works in the tests too.

megsum commented 9 years ago

I haven't done the photo tests yet so it is all good. (Except that the photo tests aren't done yet) :(