Open robinboening opened 7 years ago
@robinboening can you tell us how this can be done? With an example version & detection file?
Hey @zero-24, thanks for asking. I wanted to assign myself since I already started working on that, but I think only admins of the repo can.
done 👍
do you also work on installed extension detection?
Thanks for assigning me! 👍
My plan is to finish the basic detection first and then see how the extension detection works and implement that for Alchemy CMS also, yes.
Since I haven't seen php code for 10 years now I need to find my way into it again.
Let me know if i can help you. You can contact me via tobias.zulauf[at-sign]community.joomla.org if you need help with the PHP Code.
Maybe the examples for Joomla or WP etc. can help you 😄
Just as tip for the extension detection you can have a look into the feature/whd-hackathon
branch for examples:
e.g. here: https://github.com/CMS-Garden/cmsscanner/blob/feature/whd-hackathon/src/Detector/Adapter/JoomlaAdapter.php#L391 or https://github.com/CMS-Garden/cmsscanner/blob/feature/whd-hackathon/src/Detector/Adapter/Typo3CmsAdapter.php#L113
Thanks. Yes, I branched from whd-hackathon
.
Lets see where it goes :) First I need to get the tests running locally.
Closing as there is a PR 👍
I have just noticed that the PR just add the cms detection. So i reponen here as the extension detection is still open.
👍 Yep, exactly. Thank you!
@robinboening any update regarding the extension detection features?