CMS-Garden / cmsscanner

Detects FOSS CMS in the local filesystem
Other
39 stars 14 forks source link

Add Alchemy CMS to the scanner #39

Open robinboening opened 7 years ago

robinboening commented 7 years ago
zero-24 commented 7 years ago

@robinboening can you tell us how this can be done? With an example version & detection file?

robinboening commented 7 years ago

Hey @zero-24, thanks for asking. I wanted to assign myself since I already started working on that, but I think only admins of the repo can.

zero-24 commented 7 years ago

done 👍

zero-24 commented 7 years ago

do you also work on installed extension detection?

robinboening commented 7 years ago

Thanks for assigning me! 👍

My plan is to finish the basic detection first and then see how the extension detection works and implement that for Alchemy CMS also, yes.

Since I haven't seen php code for 10 years now I need to find my way into it again.

zero-24 commented 7 years ago

Let me know if i can help you. You can contact me via tobias.zulauf[at-sign]community.joomla.org if you need help with the PHP Code.

Maybe the examples for Joomla or WP etc. can help you 😄

zero-24 commented 7 years ago

Just as tip for the extension detection you can have a look into the feature/whd-hackathon branch for examples:

e.g. here: https://github.com/CMS-Garden/cmsscanner/blob/feature/whd-hackathon/src/Detector/Adapter/JoomlaAdapter.php#L391 or https://github.com/CMS-Garden/cmsscanner/blob/feature/whd-hackathon/src/Detector/Adapter/Typo3CmsAdapter.php#L113

robinboening commented 7 years ago

Thanks. Yes, I branched from whd-hackathon.

Lets see where it goes :) First I need to get the tests running locally.

robinboening commented 7 years ago

PR landed: https://github.com/CMS-Garden/cmsscanner/pull/40

zero-24 commented 7 years ago

Closing as there is a PR 👍

zero-24 commented 7 years ago

I have just noticed that the PR just add the cms detection. So i reponen here as the extension detection is still open.

robinboening commented 7 years ago

👍 Yep, exactly. Thank you!

SniperSister commented 6 years ago

@robinboening any update regarding the extension detection features?