search

CMS-Garden / cmsscanner

Detects FOSS CMS in the local filesystem
Other
40 stars 14 forks source link

Implement no extension detection message if it is not implemented in the adapter #41

Closed zero-24 closed 7 years ago

zero-24 commented 7 years ago

Implement no extension detection message if it is not implemented in the adapter

cc @SniperSister

zero-24 commented 7 years ago

Actual result

root@localhost:~/cmsscanner/cmsscanner# ./bin/cmsscanner cmsscanner:detect /var/www --modules
Successfully finished scan!
CMSScanner found 11 CMS installations!

+-----------+-----------------+-----------+
| CMS       | # Installations | # Modules |
+-----------+-----------------+-----------+
| Joomla    | 6               | 6         |
| Drupal    | 1               | 0         |
| TYPO3 CMS | 1               | 3         |
| Contenido | 2               | 2         |
| WordPress | 1               | 1         |
+-----------+-----------------+-----------+

Module specific stats:
Joomla:
Unsupported Feature: ModuleDetection
Drupal:
+---------+-----------------+
| Module  | # Installations |
+---------+-----------------+
| Unknown | 0               |
+---------+-----------------+
TYPO3 CMS:
+-------------------------+-----------------+
| Module                  | # Installations |
+-------------------------+-----------------+
| Speaking URLs for TYPO3 | 1               |
| News events             | 1               |
| News system             | 1               |
| Unknown                 | 0               |
+-------------------------+-----------------+
Contenido:
Unsupported Feature: ModuleDetection
WordPress:
+-------------------+-----------------+
| Module            | # Installations |
+-------------------+-----------------+
| Akismet Anti-Spam | 1               |
| Unknown           | 0               |
+-------------------+-----------------+

Execution time: 1.3286311626434 seconds
Memory consumption: 4M

I'm not happy with it nor the implementation. maybe you have a better idea?

What about a global I'm system x and i support feature X,Y but not Z? Like I'm system X with Name Y?

But I'm also not sure about the output. Maybe you have a better idea on that than the current implementation?

zero-24 commented 7 years ago

FYI i have munted the joomla adapter as we have installed a lot extensions here on this system ;)

SniperSister commented 7 years ago

I refactored your code to a slightly different solution, see eaa8aabc74249d8803ec4c486d207b9682c199fc

Thanks again!