search

CMS-HGCAL / rpi-daq

Deprecated. Use gitlab version instead:
https://gitlab.cern.ch/cms-hgcal-tb/rpi-daq
0 stars 4 forks source link

Copy-paste typo? #7

Closed adavidzh closed 6 years ago

adavidzh commented 6 years ago

Is this a (copy-paste) typo? Because the exact same action was taken just above; unclear what its function is.

artlbv commented 6 years ago

In the original file there is just a return for the high level: https://github.com/CMS-HGCAL/rpi-daq/blob/master/gpiolib.c

Le 1 mai 2018 à 09:55, André David notifications@github.com a écrit :

Is there a (copy-paste) typo here because the exact same action was taken just above?

Should it be ACKpin instead, as hinted by the preceding (test-conditional](https://github.com/CMS-HGCAL/rpi-daq/blob/python/src/gpiohb.c#L90-L91)?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

adavidzh commented 6 years ago

Indeed, it looks like it creeped in in this commit.

adavidzh commented 6 years ago

Addressed as part of #8.