search

CMSCompOps / WmAgentScripts

CMS Workflow Team Scripts
7 stars 51 forks source link

Assignor: Drop the unnecessary params #1069

Open haozturk opened 2 years ago

haozturk commented 2 years ago

Impact of the new feature Assignor

Is your feature request related to a problem? Please describe. WMCore has dropped some legacy params from workflow dict: https://github.com/dmwm/WMCore/issues/9639 We shouldn't use then in workflow assignment anymore

Describe the solution you'd like Drop these params in workflow assignment:

custodialSubType, custodialGroup, nonCustodialSubType , autoApproveSites and nonCustodialGroup

@amaltaro please let me know if there is something that i'm missing

Describe alternatives you've considered None

Additional context None

amaltaro commented 2 years ago

I think this is all that is needed on the Unified side. Sorry for the belated heads up btw!

haozturk commented 2 years ago

Thanks Alan. We still have workflows being assigned w/ these params. Are they going to have problems?

amaltaro commented 2 years ago

If you provide a key/value that is not supported either at creation or workflow assignment, yes it will fail.

haozturk commented 2 years ago

since when?

I mean since when the 5 params listed above aren't supported?

haozturk commented 2 years ago

Oh, these are not the exact params. They should start w/ capital letters and it's AutoApproveSubscriptionSites not autoApproveSites. Darn, changing the code again