search

CMSCompOps / wtc-console

MIT License
1 stars 1 forks source link

is user name properly set #32

Closed vlimant closed 4 years ago

vlimant commented 4 years ago

the field "user"

https://github.com/CMSCompOps/WmAgentScripts/blob/0c45578c1171700953e090b9ddc5345115e0b2e5/Unified/actor.py#L581

does not seem to be set @dabercro ; what is the alternative field ?

dabercro commented 4 years ago

SSO hasn't been integrated yet. The plan was to get the user from there. For now, there is no user field set in the MongoDB.

If everything is otherwise working for you, we can make another push to wrap that part up.

vlimant commented 4 years ago

the user has been set properly at some point, don't you have the user name registration in the console itself? being able to see who took the action is useful IMO FYI @sharad1126

dabercro commented 4 years ago

Ah, I got confused because of which repository this was opened for. I think that was only set up for the old console. Are you reading actions from the MongoDB or the old web API?

On Wed, Dec 4, 2019, 4:25 AM vlimant notifications@github.com wrote:

the user has been set properly at some point, don't you have the user name registration in the console itself? being able to see who took the action is useful IMO FYI @sharad1126 https://github.com/sharad1126

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CMSCompOps/wtc-console/issues/32?email_source=notifications&email_token=AB4XBBXUDQ3BKXSNJ6UKAS3QW6ARHA5CNFSM4JNIBKNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4PNGI#issuecomment-561575577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XBBRWBUHC27UZTIVFUKTQW6ARHANCNFSM4JNIBKNA .

vlimant commented 4 years ago

old api. this might indeed be against the wrong repo ; apologies for the confusion.

dabercro commented 4 years ago

Ah okay. I'm traveling right now, but I'll take a look at the old API when I get back.

On Wed, Dec 4, 2019, 10:21 AM vlimant notifications@github.com wrote:

old api. this might indeed be against the wrong repo ; apologies for the confusion.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CMSCompOps/wtc-console/issues/32?email_source=notifications&email_token=AB4XBBSOL75FMAPDSDQJMSTQW7DHNA5CNFSM4JNIBKNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5MAJA#issuecomment-561692708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XBBQLCGB3XWSCBHKN6TDQW7DHNANCNFSM4JNIBKNA .

dabercro commented 4 years ago

Okay, I found the problem. It should be fixed now, so actions submitted after today will have the user parameter again.

vlimant commented 4 years ago

better