CMSTrackerDPG / DQMExplore

A repository with all the data exploration tools for DQM/DC input data
0 stars 4 forks source link

generate_me_dict function has some hand-picking of me_id values for handling 2D MEs that is now obsolete #8

Open gbenelli opened 1 month ago

gbenelli commented 1 month ago

IT seems this line has some obsolete if to handle 2D MEs: the logic should check the y_bin/bin/min/max values in the DF (in case queries could include both 1D and 2D histos, otherwise, just check for column names in the DF). https://github.com/CMSTrackerDPG/DQMExplore/blob/6ee04b84eab9a78c302ffc13e47c8a3096d99a09/src/dqmexplore/dataproc.py#L27

roy-cruz commented 1 month ago

Fixed it with the latest commit which implements a new class, MEData which handles data from DIALS. Please check corresponding PR.