Bug fixes, refactoring, updated notebooks & improvements

CMSTrackerDPG / DQMExplore

A repository with all the data exploration tools for DQM/DC input data

0 stars 4 forks source link

Bug fixes, refactoring, updated notebooks & improvements #9

Open roy-cruz opened 1 week ago

roy-cruz commented 1 week ago

The first few commits in this PR fix some issues found during testing by Richa, Tetiana & Mohammed (thanks for the feedback!). Changes committed so far:

Changed how the dimensionality of the data is checked to account for new MEs added to DIALS
Added argument in OMS query which fixes the issue with OMS queries of runs that have > 100 LSs

Please do not merge yet as there are changes under development yet to be committed which ought to be part of this PR. Any feedback on the changes would be welcome.

roy-cruz commented 17 hours ago

These latest commits add a new class named MEData which handles the data from DIALS and integrates many of the methods that were being handled as unorganized utility functions before hand, but were central to the functionality of DQMExplore. I have kept these utilities also in src/dqmexplore/utils for now since the code that does trend plotting has yet to be updated to use MEData. However, the other plotting code is already using this new class.

roy-cruz commented 17 hours ago

As a final step before this PR is ready, I will update and clean the notebooks, as well as adapt the trend plotting functionality to use the new code.

I have also added an anomaly object class, but that will be in a separate PR.

roy-cruz commented 3 hours ago

Adapted trend plotting to use the MEData class.

In the trend plotting code, the statistic which represented the MPV was mislabeled as max. I fixed this and added a new statistic which is the actual max of the distribution.