search

CMSTrackerDPG / MLplayground

Web application for collaborating to build ML models for Tracker DQM/DC
4 stars 2 forks source link

DQMIO file support #78

Closed vicha-w closed 1 year ago

vicha-w commented 2 years ago

Hi,

As discussed in Mattermost, I have added the initial version of DQMIO file support for MLPlayground. I have also added histograms/DQMIOReader.py, which is a direct copy from https://github.com/LukaLambrecht/ML4DQMDC-PixelAE/blob/master/dqmio/src/DQMIOReader.py.

This PR is not yet tested, and I am unsure how to test this, but I have a sample nanoDQMIO file with one lumisection and 19k monitoring elements.

I will discuss with Luka and check if there are any DQMIO files we can read off from EOS. In the meantime, I will also have to write some tests in histograms/tests.py as well.

As always, please let me know what you think.

Vichayanun

vicha-w commented 2 years ago

CI also complained that we don't have pyROOT. Can we have pyROOT in MLPlayground? Or at least I will try to make this work with uproot...

vicha-w commented 1 year ago

I have just written a set of tests on nanoDQMIO file. Since a nanoDQMIO file contains both 1D and 2D, testing for file import completeness and duplicates should be done after 1D and 2D histograms are imported.

With this test, I have made some modifications to from_dqmio methods to make the testing work. I have also added a test nanoDQMIO file provided by Luka here.