CMSgov / bluebutton-site-static

CMS Blue Button API website and developer docs
https://bluebutton.cms.gov
10 stars 12 forks source link

Sample data Coding.system doesn't match IG #111

Open jmandel opened 6 years ago

jmandel commented 6 years ago

https://github.com/CMSgov/bluebutton-site-static/blob/1ff11de7498bbbda58c1fc3e09b7d872360a849c/assets/ig/ValueSet-race.html#L136 refers to https://bluebutton.cms.gov/assets/ig/CodeSystem-race

https://github.com/CMSgov/bluebutton-site-static/blob/901b17b93b94ad3da90e2c32fba62529915bfa23/sample-patient-entry.json#L8 instead uses https://bluebutton.cms.gov/resources/variables/race

The instance data should match the Coding.system URLs defined in the implementation guide; and this applies to sample instance data too. This isn't just an issue with the in-spec examples; the actual deployed sandbox data (e.g., https://sandbox.bluebutton.cms.gov/v1/fhir/Patient/19990000000001) has this issue too.

jcgeer commented 6 years ago

This is an issue we are aware of but have not ironed out as of yet.

When we created the IG we used some tools that required us to create the CodeSystem and ValueSet pages that you've pointed out the extensions are linked to, whereas the sample data is linked to the resources at https://bluebutton.cms.gov/resources/variables/. Whether we change the IG to point directly to those other resources, or we change the data to link directly to the IG is a topic for future discussion of ours. Right now however it is important to note that the CodeSystem/ValueSet pages that we generated within the IG were created directly from the same resources at the https://bluebutton.cms.gov/resources/variables/ link, so it is still the same data, just in slight different formats.

jmandel commented 6 years ago

Thanks! "Same data" is a good start.

The system value is typically used by a client application to interpret these data, which makes it a bit tricky to get the logic right today. This is especially true for our Sync for Science work on data validation, since we can only validate if we know the "rules" to check against.

No worries for now, though; we'll continue to track this.