CMSgov / bluebutton-web-server

Blue Button API
https://sandbox.bluebutton.cms.gov
Other
40 stars 24 forks source link

BB2-2776: Replace ssm calls with secretsmanager in scripts #1188

Closed jimmyfagan closed 6 months ago

jimmyfagan commented 7 months ago

JIRA Ticket: BB2-2776

User Story or Bug Summary: This PR is one of the last remaining steps to eliminate our need for ssm param store. Some scripts in our repo were still looking at ssm, but were able to be updated to get the same values from secrets manager.

What Does This PR Do?

This PR swaps out some ssm calls in scripts with secretsmanager calls. Since these updated selenium testing scripts, I also used the opportunity to fix some misses on my previous selenium test update, just minor changes to comments and readmes.

What Should Reviewers Watch For?

I tested this by running the selenium remote tests against SBX and PROD and running my local version of the app after sourcing the secrets via the script. Everything seems to work out.

If you're reviewing this PR, please check these things, in particular:

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

What Needs to Be Merged and Deployed Before this PR?

None

Any Migrations?

Submitter Checklist

I have gone through and verified that...: