User Story or Bug Summary:
We have switched all Sandbox apps over to 13-month category. However, any existing (synthetic) access grants won't have an end date to them unless we run a script to update those. This task is to create and run a script to update all EXISTING access grants so they have an end date, 13 months from the date of the script running.
What Does This PR Do?
Addresses the need to apply access grant updates to all applications.
What Should Reviewers Watch For?
If you're reviewing this PR, please check these things, in particular:
Locally run the script with various kinds of access grants
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
Does this PR add any new software dependencies? No.
Does this PR modify or invalidate any of our security controls? No.
Does this PR store or transmit data that was not stored or transmitted before? No.
If the answer to any of the questions below is Yes, then please add a Security Engineer and ISSO as a reviewer, and note that this PR should not be merged unless/until he also approves it.
Do you think this PR requires additional review of its security implications for other reasons? No.
Any Migrations?
[ ] Yes, there are migrations
[ ] The migrations should be run PRIOR to the code being deployed
[ ] The migrations should be run AFTER the code is deployed
[ ] There is a more complicated migration plan (downtime, etc)
[x] No migrations
Submitter Checklist
I have gone through and verified that...:
[x] This PR is reasonably limited in scope, to help ensure that:
It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
There isn't too much of a burden on reviewers.
Any problems it causes have a small "blast radius".
It'll be easier to rollback if that becomes necessary.
[x] This PR includes any required documentation changes, including README updates and changelog / release notes entries.
[x] All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
[x] All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
[x] Reviews are requested from both:
At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
[x] Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
Please review the standards every few months to ensure you're familiar with them.
JIRA Ticket: BB2-3243
User Story or Bug Summary: We have switched all Sandbox apps over to 13-month category. However, any existing (synthetic) access grants won't have an end date to them unless we run a script to update those. This task is to create and run a script to update all EXISTING access grants so they have an end date, 13 months from the date of the script running.
What Does This PR Do?
Addresses the need to apply access grant updates to all applications.
What Should Reviewers Watch For?
If you're reviewing this PR, please check these things, in particular:
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
Any Migrations?
Submitter Checklist
I have gone through and verified that...:
READMEupdates and changelog / release notes entries.TODOand/orFIXMEcomments, which include a JIRA ticket ID for any items that require urgent attention.