CMSgov / bluebutton-web-server

Blue Button API
https://sandbox.bluebutton.cms.gov
Other
40 stars 24 forks source link

BB2-3285/BB2-3286: Update text of auth screens #1218

Closed jimmyfagan closed 2 months ago

jimmyfagan commented 2 months ago

JIRA Ticket: BB2-3285 BB2-3286

User Story or Bug Summary: These stories involve minor adjustments to the permissions screens for english and spanish based on feedback from research.

What Does This PR Do?

This PR updates some of the messages and translated messages that are used when rendering the authorization screen. For details on the updated designs of the pages, see Figma pages here (English) and here (Spanish).

I also included a small update to the github PR template for this repo.

What Should Reviewers Watch For?

If you're reviewing this PR, please run locally to confirm the displayed content on the pages matches the designs from Figma (note that formatting changes in Figma can be ignored based on this conversation). It would be nice to check a 13-month and a non-13 month app in English and in Spanish.

What Security Implications Does This PR Have?

None.

Submitters should complete the following questionnaire:

Any Migrations?

Submitter Checklist

I have gone through and verified that...:

JFU-NAVA-PBC commented 2 months ago

passed local selenium tests: image

JFU-NAVA-PBC commented 2 months ago

local selenium tests run with mock sls:

./docker-compose/run_selenium_tests_local.sh -p mslsx

in case BBUser00000 password changed, could change selenium test case BBUser00000 -> BBUser00001 temporarily and passing the tests.

jimmyfagan commented 2 months ago

I'm going to add one more commit to change selenium/standalone-chrome to seleniarm/standalone-chromium in Dockerfile.selenium, I was having trouble with the local selenium tests without that. @JFU-NAVA-PBC can you confirm that it still works for you with that change?

JFU-NAVA-PBC commented 2 months ago

I'm going to add one more commit to change selenium/standalone-chrome to seleniarm/standalone-chromium in Dockerfile.selenium, I was having trouble with the local selenium tests without that. @JFU-NAVA-PBC can you confirm that it still works for you with that change?

just docker composed the selenium tests, no more tweaking needed for Dockerfile.selenium, dev local life quality improved, awesome!