search

CMSgov / bluebutton-web-server

Blue Button API
https://sandbox.bluebutton.cms.gov
Other
40 stars 24 forks source link

jimfuqian/BB2-3247 Extend selenium tests validating access grant expiration date #1220

Closed JFU-NAVA-PBC closed 2 months ago

JFU-NAVA-PBC commented 2 months ago

JIRA Ticket: BB2-3247

User Story or Bug Summary:

Extend selenium tests, validate the TestApp's (access grant type = 13 month) access grant info: both text and the expiration date, in both English and Spanish.

What Does This PR Do?

Check the TestApp's access grant info on permission screen:

  1. Check the present of the expected text in EN_US and ES_ES respectively
  2. Check the expiration date in locale EN_US and ES_ES respectively is in expected format, is 13month away from current time

    This PR cannot be either merged or deployed until the following pre-requisite changes have been fully deployed:

    • CMSgov/some_repo#42

    Any Migrations?

    • [ ] Yes, there are migrations
      • [ ] The migrations should be run PRIOR to the code being deployed
      • [ ] The migrations should be run AFTER the code is deployed
      • [ ] There is a more complicated migration plan (downtime, etc)
    • [x] No migrations

    Submitter Checklist

    I have gone through and verified that...:

    • [x] This PR is reasonably limited in scope, to help ensure that:
      1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
      2. There isn't too much of a burden on reviewers.
      3. Any problems it causes have a small "blast radius".
      4. It'll be easier to rollback if that becomes necessary.
    • [x] I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
    • [ ] This PR includes any required documentation changes, including README updates and changelog / release notes entries.
    • [x] All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
    • [ ] All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
    • [x] Reviews are requested from both:
      • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
      • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
    • [ ] Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
      • Please review the standards every few months to ensure you're familiar with them.
jtheil-nava commented 2 months ago

Checked the 4 different views in spanish and it looks good.