This PR edits some of the details in the date testing for selenium tests to allow them to pass more predictably and consistently.
What Should Reviewers Watch For?
Do the tests still pass with these changes?
If errors are purposefully added such that the tests fail are the error messages helpful?
Validation
You should be able to run selenium tests to verify the changes still work. Since we're in September now, and October was previously working, it is slightly harder to verify, but feel free to change the list of month abbreviations locally to see what happens.
I've also gone through and changed the end date calculation to verify the possibilities for date abbreviations for all months. Including those here:
TestApp will have access to your data for 13 months, until Jan. 3, 2025.
TestApp will have access to your data for 13 months, until Feb. 3, 2025.
TestApp will have access to your data for 13 months, until March 3, 2025.
TestApp will have access to your data for 13 months, until April 3, 2025.
TestApp will have access to your data for 13 months, until May 3, 2025.
TestApp will have access to your data for 13 months, until June 3, 2025.
TestApp will have access to your data for 13 months, until July 3, 2025.
TestApp will have access to your data for 13 months, until Aug. 3, 2025.
TestApp will have access to your data for 13 months, until Sept. 3, 2025.
TestApp will have access to your data for 13 months, until Oct. 3, 2025.
TestApp will have access to your data for 13 months, until Nov. 3, 2025.
TestApp will have access to your data for 13 months, until Dec. 3, 2025.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
[ ] Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
security engineer's approval.
Any Migrations?
[ ] Yes, there are migrations
[ ] The migrations should be run PRIOR to the code being deployed
[ ] The migrations should be run AFTER the code is deployed
[ ] There is a more complicated migration plan (downtime,
etc)
JIRA Ticket: BB2-3327
What Does This PR Do?
This PR edits some of the details in the date testing for selenium tests to allow them to pass more predictably and consistently.
What Should Reviewers Watch For?
Do the tests still pass with these changes? If errors are purposefully added such that the tests fail are the error messages helpful?
Validation
You should be able to run selenium tests to verify the changes still work. Since we're in September now, and October was previously working, it is slightly harder to verify, but feel free to change the list of month abbreviations locally to see what happens.
I've also gone through and changed the end date calculation to verify the possibilities for date abbreviations for all months. Including those here:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
[ ] Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team security engineer's approval.
Any Migrations?