CMSgov / bluebutton-web-server

Blue Button API
https://sandbox.bluebutton.cms.gov
Other
40 stars 24 forks source link

BB2-3357: Updates to autoincrement script #1242

Closed jimmyfagan closed 1 week ago

jimmyfagan commented 2 weeks ago

JIRA Ticket: BB2-3357

What Does This PR Do?

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

Ran this without issue in the forked repo:

➜  bluebutton-web-server git:(master) ✗ ./ops/build_autoincrement_release.sh
Build auto increment release...
Pushing new tag
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 806 bytes | 806.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/jimmyfagan/bluebutton-web-server.git
 * [new tag]           r2 -> r2
Release created successfully: https://github.com/jimmyfagan/bluebutton-web-server/releases/tag/r2

Additionally did some testing by using this script in the main repo with my SSO deauthorized and got this:

➜  bluebutton-web-server git:(master) ✗ ./ops/build_autoincrement_release.sh                               
Build auto increment release...
Error during release creation, dumping debug output!
Release JSON payload:
{
"tag_name": "r129",
"name": "r129",
"body": "r129 - 2024-09-06\n================\n\n- BB2-3327: Fix date comparisons in selenium tests (#1240) ",
"draft": false,
"prerelease": false
}
Release API status:
{
  "message": "Resource protected by organization SAML enforcement. You must grant your Personal Access token access to this organization.",
  "documentation_url": "https://docs.github.com/articles/authenticating-to-a-github-organization-with-saml-single-sign-on/",
  "status": "403"
}
Rolling back pushed tag
To https://github.com/CMSgov/bluebutton-web-server
 - [deleted]           r129
Deleting local tag
Deleted tag 'r129' (was ed11736f)

Previously that case would have reported "Release created successfully"

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

Any Migrations?