Closed tamara-corbalt closed 1 month ago
@tamara-corbalt It looks like the uncontrolled version of the React component is not functioning right because it is expecting an onChange
function to be passed in.
If you observe the console while trying to make a change, you'll see a big red error blob of text.
@jack-ryan-nava-pbc and & @pwolfert, I pushed up changes that should resolve the issues you called out. When time allows, let me know what you think!
If you observe the console while trying to make a change, you'll see a big red error blob of text.
@jack-ryan-nava-pbc, I realized after reading this that my PR never made onChange
optional. But I don't actually know where you were seeing these errors. Can you list your reproduction steps?
Hi @pwolfert! @jack-ryan-nava-pbc is out sick today. Here's how you should be able to reproduce the behavior Jack was referring to here:
SingleInputDateField
.You should see the type error in the console as described.
Summary
ds-date-field
web component. See Jira ticket for details: https://jira.cms.gov/browse/WNMGDS-2848How to test
yarn run storybook
Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.If this is a change to design:
If this is a change to code:
yarn test:unit:update
) and browser-test snapshots (yarn test:browser:update
)If this is a change to documentation: