Closed kim-cmsds closed 1 month ago
I am experiencing some unexpected behavior that is going to be tricky to convey verbally, but here goes. Seems like the theme switcher is not properly changing the Figma library link when the theme is changed. The theme is changed properly on initial page load, but the theme switcher sets the url back to the generic Design System link instead of the theme specific link.
Steps to reproduce:
alert
component with the Core theme chosenautocomplete
component page then back to the alert
component page@jack-ryan-nava-pbc, I was able to replicate this:
I am experiencing some unexpected behavior that is going to be tricky to convey verbally, but here goes. Seems like the theme switcher is not properly changing the Figma library link when the theme is changed. The theme is changed properly on initial page load, but the theme switcher sets the url back to the generic Design System link instead of the theme specific link.
Steps to reproduce:
- Select the
alert
component with the Core theme chosen- Open the Figma library in your local instance of Figma desktop (not browser Figma)
- You'll be sent to the Design System Library - okey dokey
- Change theme from Core to Medicare
- Open Figma
- Still sent to Design System Library - hmm
- Leave Medicare theme selected
- Go to
autocomplete
component page then back to thealert
component page- Open Figma
- Sent to Medicare specific Figma library - ok, but hmm?
- Switch theme to Healthcare or CMS
- Open Figma
- Go to Design System library?
Additional steps I followed:
Could this point towards a caching issue or a missed update in the theme-switching logic?
@tamara-corbalt and @jack-ryan-nava-pbc I think this is an issue with gatsby when deployed with gh-pages
.
If you go to another branch that is deployed with gh-pages
(https://cmsgov.github.io/design-system/branch/pwolfert/release-11-blog-post/components/alert/?theme=medicare) and follow the same step series (more or less) then you'll notice that the sketch link is not updating based on the theme switcher.
I was not able to reproduce this locally or on the production site.
@malloryiden thank you for the thorough review! I'm re-requesting your review for those 3 components you pointed out:
@tamara-corbalt and @jack-ryan-nava-pbc: I pushed up changes that should resolve the issues you pointed out
Summary
How to test
Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.