CMSgov / design-system

Open source design and front-end development resources for creating Section 508 compliant, responsive, and consistent websites.
https://design.cms.gov
Other
312 stars 85 forks source link

[WNMGDS-2861] Adds Email, Link, RSS & What's New Icon components #3202

Closed tamara-corbalt closed 4 weeks ago

tamara-corbalt commented 1 month ago

Summary

Adds four new icon components:

See Jira ticket for details: WNMGDS-2861. Please note that a Download icon has already been added to the codebase.

How to test

  1. Run yarn storybook.
  2. Navigate to the Icons section and verify the presence and appearance of the new icons.

Checklist

Screenshot 2024-08-14 at 3 19 39 PM Screenshot 2024-08-14 at 3 19 57 PM Screenshot 2024-08-14 at 3 20 07 PM Screenshot 2024-08-14 at 3 20 23 PM Screenshot 2024-08-14 at 3 20 49 PM
tamara-corbalt commented 4 weeks ago

@jack-ryan-nava-pbc I like the idea of supporting viewBox controls because it gives Storybook users the flexibility to customize the icons. However, I'm concerned about the added complexity to our Storybook configuration and the potential for misuse. Could changing the proportions of the icons potentially distort the layout of the icon table?