search

CMSgov / hpt-validator-cli

CLI for validating CMS Hospital Price Transparency machine-readable files
Other
4 stars 3 forks source link

CLI and online validator give different results #13

Closed dvillaveces-tq closed 1 month ago

dvillaveces-tq commented 1 month ago

Issue Report

Some files are marked as 100% valid by the online validator, but not the CLI validator

Expected behavior

I would expect the same file to give the same result on the CLI and web validator.

Actual behavior

This file passes the online validator (see screenshot). Screenshot 2024-07-30 at 4 20 45 PM

But the same file throws errors when using the CLI validator:

Screenshot 2024-07-30 at 4 24 08 PM
  1. There is some extra white space around the affirmation value
  2. Date is in the wrong format (found after fixing the first issue manually)

Steps to reproduce the behavior

  1. Download the linked file
  2. Run it through the CLI validator using cms-hpt-validator 223601678_Trinitas-Regional-Medical-Center_standardcharges.csv v2.0.0
  3. Run the same file through the online validator at https://cmsgov.github.io/hpt-tool/online-validator/
CarlsonErin commented 1 month ago

We are unable to replicate this issue. We believe you are using an older version of the CLI. You can update to the latest version of the cli by running: npm update -g hpt-validator-cli

dvillaveces-tq commented 1 month ago

Thanks, that did it