CMSgov / hpt-validator

Validation library for CMS Hospital Price Transparency machine-readable files
Other
4 stars 5 forks source link

Detect duplicate columns for standard charges #15

Closed mint-thompson closed 8 months ago

mint-thompson commented 8 months ago

Duplicates are already being detected for header columns. This PR adds duplicate detection for standard charge columns.

mint-thompson commented 8 months ago

Logic looks good (with the tests). Just want to double check that the error message is clear enough. I would only suggest a minor change with adding text akin to "...duplicated. Only one "${column}" is allowed as a header."

We'll have to check with the team for an updated message. It will probably need to be similar to what the duplicate header column message will be changed to.