search

CMSgov / price-transparency-guide-validator

Validation tool to check output files required by the price-transparency-guide
Apache License 2.0
29 stars 13 forks source link

Git submodule #69

Closed timrburnham closed 1 year ago

timrburnham commented 2 years ago

Should rapidjson and tclap libraries be linked to their upstream sources and pinned to specific versions in source control?

One approach is git submodule. This is a bit of a project re-org, but I will submit a PR for review.

shaselton-usds commented 2 years ago

@timrburnham Thanks for the PR -- took a look and everything appears to be running well though I did have to run a few git submodule commands before everything played nicely. I left a comment in the PR concerning that.

Thanks again.

shaselton-usds commented 1 year ago

Just following up on this -- thanks for the input and we merged in the changes!

Thanks again!