CMSgov / qpp-measures-data

QPP Measures Data
90 stars 46 forks source link

QPPSE-81_update_benchmarks_2022 #687

Closed varunkarne closed 1 year ago

varunkarne commented 1 year ago

Motivation for change

PY22 benchmark final update

What is being changed

Benchmarks JSON

Release checklist:

Tasks that must be done prior to merging this PR, including testing.

Associated JIRA tickets:
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

varunkarne commented 1 year ago

Varun,

  1. why are we updating ACEP19 which is a Historic Benchmark, lines 3906-7, 3911-12, 3914-18 (removed)? Note: the deciles listed on lines 4330 - 4346 added, match what is already in the repo, I was just surprised to see that one indicated as changed.
  2. ACMS4, line 4094, 4651 --> There was just a PR to update the HB to be divided by 100. So line 4094 was 1, instead of 100 after that change. Can we leave line 4094 at 1?

@michelingle For 1. it was just how the changes diff is showing up, can confirm no changes were made to ACEP19

  1. Updated